rust: add new api for initialization#909
Closed
BennoLossin wants to merge 11 commits into
Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my newest version of the pinned-initialization API. You can find it as a stand-alone crate here: pinned-init.
I plan to squash 276ae43 onto 50f2121. I separated the commits for better earlier review.
I also need to provide a better commit message better explaining the API (linking to my blog might help, but it is a long read, so...).
I removed all
unsafeinitialization API from thesyncmodule. If we still want to keep the old API and we want to deprecate it instead just let me know.Closes #772